Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Jul 16, 2025

This PR implements a minimal Russian greeting functionality as requested in the issue. The change adds "привет" (hello) to the YDB embedded UI cluster overview section.

Changes Made

Internationalization (i18n) Updates

  • Added src/containers/Cluster/i18n/ru.json - Complete Russian translation file for the Cluster component, including the new greeting
  • Updated src/containers/Cluster/i18n/en.json - Added "Hello" greeting for consistency
  • Updated src/containers/Cluster/i18n/index.ts - Modified to import both Russian and English translations

UI Implementation

  • Updated src/containers/Cluster/ClusterOverview/ClusterOverview.tsx - Modified the overview title to display the greeting alongside the existing "Overview" text
  • The greeting now appears as:
    • Russian: "Привет - Обзор"
    • English: "Hello - Overview"

Testing

  • Added src/containers/Cluster/__test__/greeting.test.ts - Unit test to verify the greeting functionality works correctly

Technical Details

The implementation follows existing patterns in the codebase:

  • Uses the established i18n system with @gravity-ui/i18n
  • Maintains backward compatibility
  • Supports language switching between English and Russian
  • Minimal code changes with maximum reuse of existing infrastructure

Validation

  • ✅ Build successful with no errors
  • ✅ Linting passes (no new warnings introduced)
  • ✅ Unit tests pass
  • ✅ i18n system properly configured for both languages

Screenshot

YDB UI with greeting implementation

Note: The screenshot shows the UI in a state where it displays a "Network Error" because no YDB backend is running. This is expected behavior. When connected to a YDB instance, the greeting will appear in the cluster overview section title.

The greeting functionality will be visible in the cluster overview section when the application is connected to a YDB cluster instance.


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Copilot AI changed the title [WIP] привет Add Russian greeting functionality to YDB embedded UI Jul 16, 2025
Copilot AI requested a review from Raubzeug July 16, 2025 11:52
Copilot finished work on behalf of Raubzeug July 16, 2025 11:52
@Raubzeug Raubzeug closed this Jul 16, 2025
@Raubzeug Raubzeug deleted the copilot/fix-555944dd-6ad9-4657-9115-70fe59e4b550 branch July 16, 2025 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants